Review Request: Fix the minimum size of some applets

[Maarten De Meyer]

> On June 13, 2012, 5:49 p.m., David Edmundson wrote:
> > applets/pastebin/pastebin.cpp, line 263
> > <http://git.reviewboard.kde.org/r/105234/diff/3/?file=67581#file67581line263>
> >
> >     Where did you get the number 33 from?

If it is 32 the iconSize() method selects a smaller icon.
iconSize() returns the biggest fitting icon, if the rectangle is 32x32 the biggest fitting icon is 16x16. This looks way too small on the desktop and is not consistent with other applets.
If the rectangle is 1 pixel higher and wider it works and looks better.


- Maarten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105234/#review14700
-----------------------------------------------------------


On June 13, 2012, 7:19 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105234/
> -----------------------------------------------------------
> 
> (Updated June 13, 2012, 7:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This fixes the minimum size of the following applets: showdashboard, systemloadviewer, pastebin, weatherstation and timer.
> Some sizes were to small, so there were visual glitches and some applets had no minimum value set.
> 
> I have no commit rights.
> 
> 
> Diffs
> -----
> 
>   applets/pastebin/pastebin.cpp 208e6a3 
>   applets/showdashboard/showdashboard.cpp 1c2f623 
>   applets/systemloadviewer/systemloadviewer.cpp b852256 
>   applets/timer/timer.cpp ba5ee66 
>   applets/weatherstation/weatherstation.cpp 8ada9c2 
> 
> Diff: http://git.reviewboard.kde.org/r/105234/diff/
> 
> 
> Testing
> -------
> 
> Run the applets with their new minimum size, and minimized.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120613/5e22587b/attachment.html>