Review Request: Fix the build system of locale qml bindings

Marco Martin notmart at gmail.com
Tue Jun 12 13:43:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105226/#review14658
-----------------------------------------------------------

Ship it!


is possible to use, tough the new location is the correct one

- Marco Martin


On June 12, 2012, 1:11 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105226/
> -----------------------------------------------------------
> 
> (Updated June 12, 2012, 1:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> right now CMakeLists.txt installs the qmldir under ${IMPORTS_INSTALL_DIR}/org/kde/plasma/locale
> it should be ${IMPORTS_INSTALL_DIR}/org/kde/locale, otherwise it won't be possible for QML to load the plugin, correct?
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/locale/CMakeLists.txt e36f2c9 
> 
> Diff: http://git.reviewboard.kde.org/r/105226/diff/
> 
> 
> Testing
> -------
> 
> it works
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120612/95598cc0/attachment.html>


More information about the Plasma-devel mailing list