Review Request: Plasmapkg: Plasmapkg -t can now detect the correct serviceType

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105215/#review14607
-----------------------------------------------------------



plasma/tools/plasmapkg/main.cpp
<http://git.reviewboard.kde.org/r/105215/#comment11548>

    there's no reason for these changes. it just means things below need to change.



plasma/tools/plasmapkg/main.cpp
<http://git.reviewboard.kde.org/r/105215/#comment11549>

    this should be:
    
    } else if (serviceType == "Plasma/LayoutTemplate") {
        type = "layout-template";
    
    and then the changes below are no longer needed.



plasma/tools/plasmapkg/main.cpp
<http://git.reviewboard.kde.org/r/105215/#comment11547>

    this will break backwards compatibility. layout-template must remain as an accepted command otherwise anyone (and their scripts) that had this working in the past will suddenly find it broken.
    
    in fact this, and the changes below to the kwin paths, are unnecessary if type is set correctly above.


- Aaron J. Seigo


On June 11, 2012, 9:56 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105215/
> -----------------------------------------------------------
> 
> (Updated June 11, 2012, 9:56 a.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Hello,
> 
> With this patch if the user types plasmapkg -t "Plasma/LayoutTemplate" -u path_to_package, then the plasmapkg is converting the "Plasma/LayoutTemplate" in "Layout/Template", in order for plasmapkg to be able to install the package. Also the same thing applies for the KWin staff...
> 
> 
> Diffs
> -----
> 
>   plasma/tools/plasmapkg/main.cpp 75d093a 
> 
> Diff: http://git.reviewboard.kde.org/r/105215/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120611/d40b8569/attachment-0001.html>