Review Request: Plasmate: Add tabbox previewer
Antonis Tsiapaliokas
kok3rs at gmail.com
Sat Jun 9 10:37:58 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105139/
-----------------------------------------------------------
(Updated June 9, 2012, 10:37 a.m.)
Review request for kwin, Plasma and Martin Gräßlin.
Changes
-------
Hello,
In this patch i have remove the "Plasma/Applet" from our serviceType, because there was a regression with the plasmapkg,the plasmapkg was thinking that the tabbox
was a plasmoid. So from now on, the plasmate doesn't create the project as a "hybrid"...
Description
-------
Hello,
This is the second task of my GSoC.Everything seems to work execpt from:
1)The icon of the refresh (in the tabbox previewer) is not visible.
2)I couldn't try if the refresh works...
This addresses bug master.
http://bugs.kde.org/show_bug.cgi?id=master
Diffs (updated)
-----
CMakeLists.txt 12f8a3a
editors/metadata/metadataeditor.cpp fce65fd
mainwindow.cpp 6f72624
previewer/tabbox/standalone/main.cpp PRE-CREATION
previewer/tabbox/standalone/windowswitcherpreviewer.h PRE-CREATION
previewer/tabbox/standalone/windowswitcherpreviewer.cpp PRE-CREATION
previewer/tabbox/tabboxdelegate.qml PRE-CREATION
previewer/tabbox/tabboxpreviewer.h PRE-CREATION
previewer/tabbox/tabboxpreviewer.cpp PRE-CREATION
previewer/tabbox/thumbnailitem.h PRE-CREATION
previewer/tabbox/thumbnailitem.cpp PRE-CREATION
previewer/tabbox/windowswitcher.h PRE-CREATION
previewer/tabbox/windowswitcher.cpp PRE-CREATION
startpage.cpp 9774b48
Diff: http://git.reviewboard.kde.org/r/105139/diff/
Testing
-------
Screenshots
-----------
http://git.reviewboard.kde.org/r/105139/s/590/
Thanks,
Antonis Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120609/0ad4527d/attachment.html>
More information about the Plasma-devel
mailing list