Review Request: Misc fixes in widget explorer tooltip including missing i18n

Marco Martin notmart at gmail.com
Fri Jun 8 18:39:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105177/#review14517
-----------------------------------------------------------

Ship it!


looks fine. i think is ok at add the new i18n there because it was already displayed untranslated anyways, so things don't get worse

- Marco Martin


On June 7, 2012, 5:31 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105177/
> -----------------------------------------------------------
> 
> (Updated June 7, 2012, 5:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add missing space in "License:" and "Author" in tooltip label of widget explorer
> Resize tooltip to match text size (instead of truncating)
> Port Text to PlasmaComponents.Label so that fonts are respected.
> add missing i18n
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml ea0606a 
> 
> Diff: http://git.reviewboard.kde.org/r/105177/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120608/79cceba9/attachment.html>


More information about the Plasma-devel mailing list