Review Request: Fix text colors on TabButton and ToolButton

Aurélien Gâteau agateau at kde.org
Wed Jun 6 14:28:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105163/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

When the widgets use the button background frame, use buttonTextColor. When they do not use any background frame, use textColor.
This avoids unreadable text with Oxygen, as visible on screenshots.


Diffs
-----

  plasma/declarativeimports/plasmacomponents/platformcomponents/touch/ToolButton.qml 71629fc 
  plasma/declarativeimports/plasmacomponents/qml/TabButton.qml 0131b12 
  plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml a10e0bf 

Diff: http://git.reviewboard.kde.org/r/105163/diff/


Testing
-------

Run Plasma widget gallery, before and after the patch.


Screenshots
-----------

before
  http://git.reviewboard.kde.org/r/105163/s/598/
after
  http://git.reviewboard.kde.org/r/105163/s/599/


Thanks,

Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120606/9b7e0328/attachment.html>


More information about the Plasma-devel mailing list