Review Request: Plasmate: Add Tabbox support to the startpage

[Antonis Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105011/
-----------------------------------------------------------

(Updated June 6, 2012, 1:27 p.m.)


Review request for kwin, Plasma and Martin Gräßlin.


Changes
-------

I have update the "templates/mainTabbox.qml" with a correct tabbox qml file.


Description
-------

Hello,

This is the first task of my GSoC. I have add the tabbox support to the startpage of the plasmate.

NOTES:

1)The service type of the tabbox is "Kwin/Tabbox,Plasma/Applet", because the Plasma::PackageStructure requires the "Plasma/Applet" in order to be able to be used. Also the plasmapkg and the plasmoidview require the "Plasma/Applet" service type.
2)Some lines doesn't have any differences because i have remove some whitespaces and "tabs"... 

ISSUES:

1)The icons for the tabbox are wrong. I have some issues with my PCs and i cannot open a new session of the KDE.
So i wasn't able to find the icon. Sorry for that.
2)The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it uses some Q_PROPERTY elements. Any ideas about how to fix that?
3)I think that the starting comments of the tabbox should become better. I would prefer something like the "mainPlasmoid.qml"....


Diffs (updated)
-----

  editors/metadata/metadataeditor.cpp fce65fd 
  startpage.h 0df4c21 
  startpage.cpp 9774b48 
  templates/CMakeLists.txt 6a82772 
  templates/mainTabbox.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105011/diff/


Testing
-------


Screenshots
-----------


  http://git.reviewboard.kde.org/r/105011/s/574/


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120606/3fbec1a2/attachment-0001.html>