Review Request: Use the same text color as C++ Plasma::LineEdit

[Sebastian Kügler]

> On June 6, 2012, 11:04 a.m., Aleix Pol Gonzalez wrote:
> > plasma/declarativeimports/plasmacomponents/qml/TextField.qml, line 305
> > <http://git.reviewboard.kde.org/r/105159/diff/1/?file=66417#file66417line305>
> >
> >     Wouldn't textColor be better than buttonTextColor?
> >     
> >     The TextField doesn't have the a button background!

The idea here is that the button background has the same color as the view background for TextEdit.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105159/#review14442
-----------------------------------------------------------


On June 6, 2012, 10:55 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105159/
> -----------------------------------------------------------
> 
> (Updated June 6, 2012, 10:55 a.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> Plasma::LineEdit uses the button text color for its text. Do the same in PlasmaComponents.TextField to avoid white text on white background with Oxygen theme.
> 
> Also use button text color for PC.TextArea because it uses the same background frame as PC.TextField (P.TextEdit, its C++ equivalent, does not have any background frame)
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml 1230d33 
>   plasma/declarativeimports/plasmacomponents/qml/TextArea.qml f82842e 
> 
> Diff: http://git.reviewboard.kde.org/r/105159/diff/
> 
> 
> Testing
> -------
> 
> Run Plasma widget gallery from kdeexamples before and after the patch, see attached screenshots.
> Note: the "before" screenshot corresponds to the state of the classes after I reverted the changes which hardcoded their text colors to black.
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/105159/s/596/
> after
>   http://git.reviewboard.kde.org/r/105159/s/597/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120606/0c48a146/attachment.html>