Review Request: Plasmate: Add tabbox previewer

Antonis Tsiapaliokas kok3rs at gmail.com
Tue Jun 5 13:42:18 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105139/
-----------------------------------------------------------

(Updated June 5, 2012, 1:42 p.m.)


Review request for kwin, Plasma and Martin Gräßlin.


Changes
-------

Hello,

In this patch i have made the previewer to be a standalone application. Also i have fix some issues that they have been creating because of this patch.
The name of the binary is windowswitcherpreviewer.

The only issue is that the refresh button of the previewer is not show, so i have put a QPushButton just for testing.


Description
-------

Hello,

This is the second task of my GSoC.Everything seems to work execpt from:

1)The icon of the refresh (in the tabbox previewer) is not visible.
2)I couldn't try if the refresh works...


This addresses bug master.
    http://bugs.kde.org/show_bug.cgi?id=master


Diffs (updated)
-----

  CMakeLists.txt 12f8a3a 
  mainwindow.cpp 6f72624 
  previewer/tabbox/standalone/main.cpp PRE-CREATION 
  previewer/tabbox/standalone/windowswitcherpreviewer.h PRE-CREATION 
  previewer/tabbox/standalone/windowswitcherpreviewer.cpp PRE-CREATION 
  previewer/tabbox/tabboxdelegate.qml PRE-CREATION 
  previewer/tabbox/tabboxpreviewer.h PRE-CREATION 
  previewer/tabbox/tabboxpreviewer.cpp PRE-CREATION 
  previewer/tabbox/thumbnailitem.h PRE-CREATION 
  previewer/tabbox/thumbnailitem.cpp PRE-CREATION 
  previewer/tabbox/windowswitcher.h PRE-CREATION 
  previewer/tabbox/windowswitcher.cpp PRE-CREATION 
  startpage.cpp 9774b48 
  templates/mainTabbox.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105139/diff/


Testing
-------


Screenshots
-----------


  http://git.reviewboard.kde.org/r/105139/s/590/


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120605/8e6572fb/attachment.html>


More information about the Plasma-devel mailing list