Review Request: Plasmate: Add tabbox previewer

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105139/#review14395
-----------------------------------------------------------


I have not yet tried it. From the code it looks quite ok, only comment is to drop the KWin specific namespaces.


previewer/tabbox/layoutpreview.h
<http://git.reviewboard.kde.org/r/105139/#comment11361>

    I would drop the KWin specific namespaces and would properly integrate it in Plasmate


- Martin Gräßlin


On June 3, 2012, 10:01 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105139/
> -----------------------------------------------------------
> 
> (Updated June 3, 2012, 10:01 a.m.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Hello,
> 
> This is the second task of my GSoC.Everything seems to work execpt from:
> 
> 1)The icon of the refresh (in the tabbox previewer) is not visible.
> 2)I couldn't try if the refresh works...
> 
> 
> This addresses bug master.
>     http://bugs.kde.org/show_bug.cgi?id=master
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 12f8a3a 
>   mainwindow.cpp 6f72624 
>   previewer/tabbox/layoutpreview.h PRE-CREATION 
>   previewer/tabbox/layoutpreview.cpp PRE-CREATION 
>   previewer/tabbox/tabboxdelegate.qml PRE-CREATION 
>   previewer/tabbox/tabboxpreviewer.h PRE-CREATION 
>   previewer/tabbox/tabboxpreviewer.cpp PRE-CREATION 
>   previewer/tabbox/thumbnailitem.h PRE-CREATION 
>   previewer/tabbox/thumbnailitem.cpp PRE-CREATION 
>   previewer/tabbox/thumbnails/dolphin.png PRE-CREATION 
>   previewer/tabbox/thumbnails/kmail.png PRE-CREATION 
>   previewer/tabbox/thumbnails/konqueror.png PRE-CREATION 
>   previewer/tabbox/thumbnails/systemsettings.png PRE-CREATION 
>   templates/mainTabbox.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105139/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/105139/s/590/
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120603/5dbbecc0/attachment.html>