Review Request: Plasmate: request to merge terietor/remoteinstaller to master

[Giorgos Tsiapaliwkas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105032/
-----------------------------------------------------------

(Updated June 1, 2012, 6:11 p.m.)


Review request for Plasma.


Changes
-------

Yesterday Aaron send some patches to kdelibs and kde-runtime
which solves the X issue(thanks Aaron).

So, the remoteinstaller is ready/working. But there are some cases in which
the remoteinstaller won't work, those are
a. if the ssh daemon isn't started
b. if the ssh port is closed
c. if the display in the other pc isn't set or isn't :0

for a,b I added a label in which I mention them.
for c I added an advanced mode ui in which the user can change the DISPLAY
var which the remote installer will use.


Description
-------

Hello,

in terietor/remoteinstaller I have create a remote installer.
The goal is to install the projects remotely to another computer.

You access the remote install either inside plasmate or using the plasmaremoteinstaller binary.


Diffs (updated)
-----

  CMakeLists.txt 12f8a3a 
  publisher/publisher.h 5f40ae0 
  publisher/publisher.cpp fd87364 
  publisher/remoteinstaller/advancedmodewidget.ui PRE-CREATION 
  publisher/remoteinstaller/remoteinstaller.h PRE-CREATION 
  publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION 
  publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION 
  publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION 
  publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION 
  publisher/remoteinstaller/standalone/main.cpp PRE-CREATION 
  publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION 
  publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105032/diff/


Testing
-------

I couldn't find any bugs in the remote installer, but the proccess fails during KIO::copy.
Apparently I am not writing correct something in the fish protocol.
Right now the remote installer tries to do the above

KIO::copy("/home/terietor/.kde4/share/apps/plasmate/project, "fish://user@ip/home/user")

but it fails


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120601/0aca593c/attachment.html>