Review Request: Don't warn when using a page without toolbar

Marco Martin notmart at gmail.com
Tue Jul 31 11:25:47 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105803/#review16701
-----------------------------------------------------------

Ship it!


good catch

- Marco Martin


On July 31, 2012, 11:24 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105803/
> -----------------------------------------------------------
> 
> (Updated July 31, 2012, 11:24 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> When executing Muon Discover, I had this warning sometimes. It's not really something that's forbidded, so we better adapt the code to this situation.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/ToolBar.qml 17b2939 
> 
> Diff: http://git.reviewboard.kde.org/r/105803/diff/
> 
> 
> Testing
> -------
> 
> Changed it and ran discover again, everything worked fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120731/bb7e3512/attachment.html>


More information about the Plasma-devel mailing list