Review Request: Make the Nepomuk runner forward all the nie:urls

Albert Astals Cid tsdgeos at terra.es
Mon Jul 30 18:23:18 UTC 2012



> On July 27, 2012, 11:46 a.m., Torgny Nyblom wrote:
> > My vote is for ship it but it is Albert who is doing the release and he is away for a few days more.
> > Perhaps better wait for him.
> 
> Albert Astals Cid wrote:
>     To be honest this looks like a long running bug (reported during 4.8 beta 1?), so i don't see why it's critical to get it in, though i'm open to explanations of why we really need to include it.
> 
> Vishesh Handa wrote:
>     I thought the tarballs had not been spun. 
>     
>     Since they have been spun, we can ignore this. It can go in 4.9.1.

Awesome, let's do the same than with the other request (close to get it off the queue and commit on wednesday after the release)


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105738/#review16520
-----------------------------------------------------------


On July 26, 2012, 5:25 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105738/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 5:25 p.m.)
> 
> 
> Review request for Nepomuk, Plasma, Release Team, and Sebastian Trueg.
> 
> 
> Description
> -------
> 
> Not just the ones that are local files. This fixes opening of emails,
> and other akonadi resources directly from the runner.
> 
> @Release Team: It would be nice to have in 4.9 :)
> 
> 
> This addresses bug 287470.
>     http://bugs.kde.org/show_bug.cgi?id=287470
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 0ea308d 
> 
> Diff: http://git.reviewboard.kde.org/r/105738/diff/
> 
> 
> Testing
> -------
> 
> Yup. Emails open up with KMail.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120730/351e9807/attachment.html>


More information about the Plasma-devel mailing list