Review Request: Clean up rtm headers and move private data from Auth and Request classes into private classes.

[Andrew Stromme]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105734/#review16486
-----------------------------------------------------------

Ship it!


Looks good, thanks for passing it by me!


libs/rtm/auth.h
<http://git.reviewboard.kde.org/r/105734/#comment12853>

    Is there a reason why Auth is no longer exported with RTM_EXPORT?


- Andrew Stromme


On July 26, 2012, 4:55 a.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105734/
> -----------------------------------------------------------
> 
> (Updated July 26, 2012, 4:55 a.m.)
> 
> 
> Review request for Plasma and Andrew Stromme.
> 
> 
> Description
> -------
> 
> rtm: Move Request private data into RequestPrivate class in .cpp file. rtm: Move Auth private data into AuthPrivate class in .cpp file. rtm: Clean up auth.h and request.h files.
> 
> 
> rtm: Clean up rtm header files.
> 
> 
> Add #include <rtm/task.h> since we use Task * (and session.h has been cleaned up).
> 
> 
> Diffs
> -----
> 
>   dataengines/rememberthemilk/taskservice.cpp d738093ffd7c5183cf24f9f932d0c7f934b6634b 
>   libs/rtm/auth.h 5f693fa53fc273e2a3782ac57e8c1ca3f8b194a1 
>   libs/rtm/auth.cpp 16fd5f0c28004dcc12140556e8d6727c483c2ed9 
>   libs/rtm/note.h af4cfd20c6ddaf1a4943f76f148c79918b5ec633 
>   libs/rtm/request.h d371714c144bf9bc6c7304a861840334f0846cdb 
>   libs/rtm/request.cpp 1304cb5d1a547d08b7f82e44cd319097991c8425 
>   libs/rtm/rtm.h 1a542f6007c63df13b79dd60da0cfcfe294f8e16 
>   libs/rtm/session.h aad145c44c70fb28fe1496b93d991667e918f630 
>   libs/rtm/xmlreaders.h b9ea78ca567e32aceb70361a2735b7b005d15777 
> 
> Diff: http://git.reviewboard.kde.org/r/105734/diff/
> 
> 
> Testing
> -------
> 
> It builds and runs ok here (the rtm applet logs in and loads data ok).
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120726/af428ae9/attachment.html>