Review Request: KRunner Bookmarks: implement Chrome/Chromium support

[Marco Gulino]

> On July 22, 2012, 11:17 p.m., Aleix Pol Gonzalez wrote:
> > I don't see the patch...?

it's in a separate branch (the one specified above) , there are too many files, a patch wouldn't be handy :-) 


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105673/#review16244
-----------------------------------------------------------


On July 22, 2012, 10:27 p.m., Marco Gulino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105673/
> -----------------------------------------------------------
> 
> (Updated July 22, 2012, 10:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> I've nearly finished my work on the Bookmarks krunner, at least I think it's ready for a review.
> Main focus: add support for chrome (and chromium).
> Side effects: refactoring, a few unit tests, and Favicons for firefox (it's very similar for chrome, they're stored as sqlite blob, so adding favicon for chrome meant making easy to add them to firefox too).
> I also removed some code seeming dead, or duplicated.
> 
> I'm mostly unhappy with the favicon fetch from firefox and chrome: i had to save them to temp file since it's impossible to load QPixmap in krunner plugins.
> 
> What's still missing: maybe a little more testing (both unit and manual) and cleanup.
> 
> branch: plasma/bookmarksrunner-chrome-gulino, path /plasma/generic/runners/bookmarks
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/105673/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Gulino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120722/d51ee547/attachment.html>