Review Request: ksplashx: Adjust erroneous CMake calls.

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105468/#review16237
-----------------------------------------------------------

Ship it!


If no one objects by Monday I'd just make the commit. It can always be reverted later if it causes an issue, and it sounds like it fixes several other problems that haven't become issues yet.

- Michael Pyne


On July 7, 2012, 3:07 a.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105468/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 3:07 a.m.)
> 
> 
> Review request for Build System and Plasma.
> 
> 
> Description
> -------
> 
> ksplashx: Adjust erroneous CMake calls.
> 
> Since its inception, ksplashx's CMakeLists.txt was using `include(FindFOO)'
> instead of `find_package(FOO)' to find libpng and libjpeg. While it has indeed
> worked so far, it is not the right way to find dependencies.
> 
> Adjust this by correctly looking for libpng and libjpeg via find_package(). The
> calls are in the top-level CMakeLists.txt since putting all find_package() and
> macro_optional_find_package() calls in the same file seems to appease some
> packagers.
> 
> While here, also add libjpeg's include directory to the compiler's include path
> and use a FindPNG variable that's not internal to do the same for libpng.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ded5a2995b3d25c1c7c891afe93795fb0dfcfb87 
>   ksplash/ksplashx/CMakeLists.txt 65447939dc9ac17c69f1e94afe935b37c7dceba4 
> 
> Diff: http://git.reviewboard.kde.org/r/105468/diff/
> 
> 
> Testing
> -------
> 
> kde-workspace built fine both before and after this change
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120722/9c4b2cc2/attachment.html>