Review Request: kickoff-qml: TabBar button width

[Greg T]

> On July 19, 2012, 9:04 a.m., Marco Martin wrote:
> > thanks, wouldn;t have remembered ;)
> > 
> > the changes seems good, but i'm not sure about giving kickoff a copy of the tabbar.
> > 
> > any reason this is not proposed as a patch for the tabbar component itself?
> 
> Greg T wrote:
>     Of course I could do that. But I didn't know if such a general change would be welcome. Maybe people love equally sized blocks?
> 
> Marco Martin wrote:
>     i really think we shouldn't start to customize the components in a single applet like that.
>     
>     what could be done is:
>     as implicit width of the tabbar should be a width such that all tabs have the same width that is the one of the largest tab, so by default it would attempt to never elide (probably some work in the bindings is needed to export this as preferred width of the applet).
>     
>     if it's forced to be smaller it starts to elide the text.

I'm not sure if I can follow you, but basically you describe the current behavior. Every TabButton got a 'implicitHeight: label.paintedHeight' and the layout calculates a minimum implicitWidth that doesn't elide text. The export is missing, though.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105405/#review16103
-----------------------------------------------------------


On July 1, 2012, 8:42 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105405/
> -----------------------------------------------------------
> 
> (Updated July 1, 2012, 8:42 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> Heda,
> This patch addresses the layout of the tab bar. The tab buttons are now sized depending of their text width.
> 
> I just copied the tabbar code from kde-runtime and exchanged taskbarLayout. My main question is: Can I do this more elegantly without copying TabBar.qml?
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/package/contents/ui/KickoffTabBar.qml PRE-CREATION 
>   plasma/desktop/applets/kickoff/package/contents/ui/Private/TabBarLayout.qml PRE-CREATION 
>   plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml 4d53208 
> 
> Diff: http://git.reviewboard.kde.org/r/105405/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120720/002c5bf2/attachment.html>