Fwd: back developing [KRunner Bookmarks for chrome]

[Marco Gulino]

Ok, pushed
branch is plasma/bookmarksrunner-chrome-gulino (based on 4.9, will forward
port to master after the review).

Basically i extracted major responsibilities into separate classes, created
an interface Browser, and added Chrome/Chromium support via QJson (should
it be an optional dependency?).
It "looks" like it's a lot more complex, but actually there's much less
code (i could delete many duplicated methods, unneeded ifs, and so on).
I also added unit test, as i previously stated.


What's missing: favicons.
Both firefox and chrome use sqlite and store icons in a blob, but it looks
like a hack is needed, since i cant load blob icons directly into a pixmap.

I tried using temporary files, and it works, but it sounds like a dirty
approach, kinda study it a little more before pushing.

Thanks
Marco

On Fri, Jul 20, 2012 at 1:59 PM, Marco Gulino <marco.gulino at gmail.com>wrote:

> Thank you, but this proxy is kinda too much restrictive, i can use https,
> but ssh on https port doesn't seem to work.
> Anyway, not a big deal... in a few hours i'll be on holiday for a whole
> month, no proxy or firewalls in the way :)
>
>
> On Fri, Jul 20, 2012 at 1:11 PM, Ben Cooksley <bcooksley at kde.org> wrote:
>>
>> In case it helps, KDE repositories are accessible over port 443
>> (usually used for https - used by SSH by us however) which most
>> restrictive firewalls and proxies have no problems in passing through.
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120720/e2aec5f5/attachment.html>