Review Request: Fix the wrong usage of "Keywords" in some .dekstop files

Aurélien Gâteau agateau at kde.org
Sat Jul 14 20:22:27 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105553/#review15858
-----------------------------------------------------------

Ship it!


Ship It!

- Aurélien Gâteau


On July 13, 2012, 2:47 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105553/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 2:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> According to the FDO specification[1][2], the type of "Keywords" is "localestring(s)", where multiple values are separated by a semicolon. 
> 
> The affected two .desktop files use comma instead of semicolon to separate multiple values. That seems to be the expected behavior for "X-KDE-Keywords", but not for "Keywords".
> 
> The patch simply uses semicolon and adds the trailing semicolon.
> 
> 
> [1] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s05.html
> [2] http://standards.freedesktop.org/desktop-entry-spec/latest/ar01s03.html
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/metadata.desktop 9a520ee 
>   plasma/generic/applets/lock_logout/metadata.desktop 6d90856 
> 
> Diff: http://git.reviewboard.kde.org/r/105553/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120714/fce2338c/attachment.html>


More information about the Plasma-devel mailing list