Review Request: fixed calendar plasmoid configuration not saved
Reza Shah
rshah0385 at kireihana.com
Sat Jul 14 11:49:27 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105569/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
This patch tries to fix bug which caused calendar configuration is not saved.
as mention in this bug: https://bugs.kde.org/show_bug.cgi?id=302958
Inside this function
void Calendar::applyConfiguration(KConfigGroup cg)
{
const bool details = isDisplayingDateDetails();
calendarTable()->applyConfiguration(cg);
if (details != isDisplayingDateDetails()) {
d->updatePreferredSize();
}
}
Should i remove calendarTable()->applyConfiguration(cg); too?
Seems it redundant with calendarTable()->configAccepted(cg);
This addresses bug 302958.
http://bugs.kde.org/show_bug.cgi?id=302958
Diffs
-----
libs/plasmaclock/calendar.cpp e2b3b41
Diff: http://git.reviewboard.kde.org/r/105569/diff/
Testing
-------
against master
Thanks,
Reza Shah
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120714/c1ddf7e4/attachment.html>
More information about the Plasma-devel
mailing list