Review Request: add little margin to tooltip position

Marco Martin notmart at gmail.com
Thu Jul 12 09:17:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105520/#review15718
-----------------------------------------------------------

Ship it!


the code of the "real" tooltips is completely different, is not done by the Dialog class.

now, try to update kdelibs and kde-workspace, i attempted to solve the problem in a slightly different way.
if a Dialog has Qt.toolTip among the window flags it shouldn't cut the borders anymore.
if bad countereffects will be encountered we can still fall back to this way

- Marco Martin


On July 12, 2012, 2:55 a.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105520/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 2:55 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> In current widget explorer, the tooltip for leftmost item is clipped, 
> this makes the appearance of tooltip and text inside it not properly displayed.
> 
> The margin value is hardcoded, i like to have the same margin as the tooltip of kickoff plasmoid when placed at leftmost of the screen.
> But not sure which file should i read to get kickoff tooltip value.
> 
> I will commit this to KDE/4.9 and master if accepted.
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/widgetsexplorer/widgetexplorer.cpp 2651371 
> 
> Diff: http://git.reviewboard.kde.org/r/105520/diff/
> 
> 
> Testing
> -------
> 
> tested againts master.
> 
> 
> Thanks,
> 
> Reza Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120712/b1892207/attachment.html>


More information about the Plasma-devel mailing list