Review Request: Fix for microblog plasma applet not getting authenticated with a twitter account

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105498/#review15593
-----------------------------------------------------------


I've committed a patch which does that, tested with phoenix_fbrd on IRC.


dataengines/microblog/koauth.cpp
<http://git.reviewboard.kde.org/r/105498/#comment12164>

    we need to check if user is empty here, so we can pick d->user in that case.


- Sebastian Kügler


On July 9, 2012, 10:38 p.m., phoenix firebrd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105498/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 10:38 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> The microblog plasma applet fails to authenticate with twitter and so the timeline is empty without the post. The problem is in the microblog dataengine in KOAuth::authorize, the user parameter is empty and it overwrites the username already present in d->user. The crash part of plasma-desktop only occurs when the ok button is pressed immediately after the apply button is pressed in the settings ui. This crash is not fixed in here. Only the twitter authentication part is fixed here.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=302267.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=302267
> 
> 
> Diffs
> -----
> 
>   dataengines/microblog/koauth.cpp 565d79f 
> 
> Diff: http://git.reviewboard.kde.org/r/105498/diff/
> 
> 
> Testing
> -------
> 
> Tested, twitter account gets aunthenticated and the twitts are displayed properly in the timeline.
> 
> 
> Thanks,
> 
> phoenix firebrd
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120709/676ac507/attachment.html>