Review Request: change default config of taskmanager

[Greg T]

> On June 28, 2012, 4:57 p.m., Aaron J. Seigo wrote:
> > Items= is no longer used. individual entries are. so this review is not correct.
> > 
> > the prefered items are also indeed removable. that was fixed a while back.
> > 
> > are you using kde-workspace from master or some older branch or...?
> 
> Greg T wrote:
>     ah, I see.
>     
>     Nope, I'm using plain master and that bug is definitely *not* fixed. The preferred filemanager and browser icons keep reappaering on login. The function GroupManagerPrivate::unsaveLauncher can't remove that config entrys because the name of the launcher is i.e. 'firefox' but never 'browser'

well, I have updated the patch 1 week ago, +1/-1? :)


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105374/#review15230
-----------------------------------------------------------


On June 28, 2012, 7:03 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105374/
> -----------------------------------------------------------
> 
> (Updated June 28, 2012, 7:03 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> libtaskmanager can't remove those ("browser", "preferred://browser, , , ") entrys, so I moved them to the Items list. I don't know why they were separated in the first place. That's why I'm opening this review request.
> 
> 
> This addresses bug 278724.
>     http://bugs.kde.org/show_bug.cgi?id=278724
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/groupmanager.cpp 5ca0159 
> 
> Diff: http://git.reviewboard.kde.org/r/105374/diff/
> 
> 
> Testing
> -------
> 
> no regressions noted.
> 
> 
> Thanks,
> 
> Greg T
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120709/7c61354b/attachment.html>