Review Request: better handling of Removable property for volumes in soliddevice engine

[Andriy Gapon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105432/
-----------------------------------------------------------

(Updated July 5, 2012, 6:44 a.m.)


Review request for Plasma and Solid.


Changes
-------

Add a snippet of `solid-hardware list details` output that hopefully demonstrates the problem better than my original verbiage.


Description
-------

Currently the code in SolidDeviceEngine::populateDeviceData sets volume's Removable property in straightforward fashion:
- tries to cast volume's (immediate) parent device to Solid::StorageDrive
- if that succeeds, checks isHotpluggable() and isRemovable() properties of the parent
The problem is that there could be intermediate devices in solid device hierarchy between the volume and its Solid::StorageDrive ancestor, for example partition-type devices.

The proposed code walks up the hierarchy to try harder to find Solid::StorageDrive ancestor of a given device.

BTW, I think that getAncestorOfType() helper function introduced in the proposed change can be useful for other code too, so it might make sense to nominate it for inclusion into Solid API.


Diffs
-----

  plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp 608da25 

Diff: http://git.reviewboard.kde.org/r/105432/diff/


Testing
-------


Thanks,

Andriy Gapon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120705/8ab63df7/attachment.html>