Review Request: use window role to detect the dashboard

[Andreas Demmer]

> On July 4, 2012, 7:57 a.m., Andreas Demmer wrote:
> > Ship It!

I missed that windowRole would be a much better distinction than windowClass is when I initially implemented this effect. Your patch definitely makes sense, so ship it!


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105382/#review15359
-----------------------------------------------------------


On June 28, 2012, 7:42 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105382/
> -----------------------------------------------------------
> 
> (Updated June 28, 2012, 7:42 p.m.)
> 
> 
> Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.
> 
> 
> Description
> -------
> 
> see bug. i guess the window role is the natural and more distinct hint.
> 
> 
> This addresses bug 302523.
>     http://bugs.kde.org/show_bug.cgi?id=302523
> 
> 
> Diffs
> -----
> 
>   kwin/effects/dashboard/dashboard.cpp bb803a9 
>   plasma/desktop/shell/dashboardview.cpp d6762b6 
> 
> Diff: http://git.reviewboard.kde.org/r/105382/diff/
> 
> 
> Testing
> -------
> 
> yes, dashboard still triggers the effect, renamed xterm no longer
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120704/1e33fb54/attachment.html>