Review Request: make UNC path work in krunner by mapping it to smb:// path

Martin Koller kollix at aon.at
Sun Jan 29 22:14:24 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103826/
-----------------------------------------------------------

(Updated Jan. 29, 2012, 10:14 p.m.)


Review request for Plasma.


Changes
-------

changed matching algorithm from using home-brewn code to using KUriFilter method with "kshorturifilter" filter.

KUriFilter docu:
kshorturifilter: This is used for filtering potentially valid url inputs such as "kde.org" Additionally it filters shell variables and shortcuts such as $HOME and ~ as well as man and info page shortcuts, # and ## respectively.

The nice thing is that it's now also possible to use e.g. $HOME/bin


Description
-------

revive the possibility to enter an UNC path e.g. \\hostname\some\path into krunner leading to an smb://hostname/some/path target as is done in konqueror's address bar.


This addresses bug 211317.
    http://bugs.kde.org/show_bug.cgi?id=211317


Diffs (updated)
-----

  plasma/generic/runners/locations/locationrunner.cpp c8ec8ae 

Diff: http://git.reviewboard.kde.org/r/103826/diff/diff


Testing
-------


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120129/49880c1c/attachment.html>


More information about the Plasma-devel mailing list