Review Request: Improve the QML RunnerModel

[Aleix Pol Gonzalez]

> On Jan. 27, 2012, 7:21 p.m., Marco Martin wrote:
> > it looks good to me, (and proably you're right 90% of qml models a qabstractlistmodel could be enough)
> > only thing that i am usire of is the runnerforid function

Just that runnerForIndex thing, please comment on it and I'll submit another patch without the trailing whitespaces and "fuuuu".

Thanks!!


> On Jan. 27, 2012, 7:21 p.m., Marco Martin wrote:
> > components/runnermodel/runnermodel.cpp, lines 188-189
> > <http://git.reviewboard.kde.org/r/103806/diff/1/?file=48051#file48051line188>
> >
> >     why a direct access for the runner is needed?

Well, now that you say it it's just used for the section. We can add a new role that does this indoors, I can see benefit in accessing the runner in terms of flexibility, though.

If we limit the model user to the roles we might end up making the API not scalable over the time.

Since I'm an alien over here, I'll let you decide what's best. :)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103806/#review10160
-----------------------------------------------------------


On Jan. 27, 2012, 6:06 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103806/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2012, 6:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Adds some features to the RunnerModel so that it can be used properly in the KRunner QML implementation I've been working on (see the testing section).
> 
> Also it simplifies the code a bit by moving from QAbstractItemModel -> QAbstractListModel.
> 
> 
> Diffs
> -----
> 
>   components/runnermodel/runnermodel.h 899bf1f 
>   components/runnermodel/runnermodel.cpp a226f8e 
> 
> Diff: http://git.reviewboard.kde.org/r/103806/diff/diff
> 
> 
> Testing
> -------
> 
> use it in kde:scratch/apol/krunner-qml (proof of concept for a KRunner implemented in QtQuick).
> 
> here's a video, so that you know what's going on: http://www.proli.net/meu/netrunner/qmlrunner.ogv
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120129/01345e57/attachment.html>