Review Request: Add accepted signal to TextField

Aaron J. Seigo aseigo at kde.org
Fri Jan 27 10:47:32 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103795/#review10122
-----------------------------------------------------------

Ship it!


looks good; the signal needs to be added to the documentation. once the documentation is updated, this can go in.. cheers :)

- Aaron J. Seigo


On Jan. 26, 2012, 9:55 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103795/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2012, 9:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Adds an accepted signal to the TextField component.
> 
> It's on the meego and native components too, so I guess it makes sense.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml 8654033 
> 
> Diff: http://git.reviewboard.kde.org/r/103795/diff/diff
> 
> 
> Testing
> -------
> 
> Tested locally in a small application.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120127/7ff3ffbb/attachment.html>


More information about the Plasma-devel mailing list