Review Request: Drop Xinerama related options in KWin

Martin Gräßlin kde at martin-graesslin.com
Thu Jan 26 06:47:02 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103756/
-----------------------------------------------------------

(Updated Jan. 26, 2012, 6:47 a.m.)


Review request for kwin and Plasma.


Changes
-------

* dropped one more option
* simplified the clientArea() method by merging the parts returning the same values.


Description
-------

As discussed on the mailinglist: drop of the xinerama related options and the kcm. Given that the show unmanaged windows on option is in fact not used, I dropped the complete KCM.


Diffs (updated)
-----

  kcontrol/CMakeLists.txt 8cd9a46 
  kcontrol/xinerama/CMakeLists.txt fe332e5 
  kcontrol/xinerama/Messages.sh f4aa134 
  kcontrol/xinerama/interface_util.h 8a4fcd1 
  kcontrol/xinerama/kcmxinerama.h 18b9241 
  kcontrol/xinerama/kcmxinerama.cpp a456b2c 
  kcontrol/xinerama/test_kcm_xinerama.cpp a358a2c 
  kcontrol/xinerama/xinerama.desktop e8ce525 
  kcontrol/xinerama/xineramawidget.h 2c446a2 
  kcontrol/xinerama/xineramawidget.cpp df9cb2f 
  kcontrol/xinerama/xineramawidget.ui 90ec4d4 
  kwin/geometry.cpp a414e26 
  kwin/manage.cpp c551eac 
  kwin/options.h 9dc29cf 
  kwin/options.cpp d496569 
  kwin/tabbox/tabbox.cpp 3051316 
  kwin/toplevel.cpp ffe7f0c 
  kwin/workspace.cpp 69b4ecb 

Diff: http://git.reviewboard.kde.org/r/103756/diff/diff


Testing
-------

Fullscreen: works
Maximize: works
Movment: works
Placement: works


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120126/0dc5fd3a/attachment-0001.html>


More information about the Plasma-devel mailing list