Review Request: Drop Xinerama related options in KWin

[Thomas Lübking]

> On Jan. 22, 2012, 6:09 p.m., Alex Fiestas wrote:
> > Tested and everything works as expected :) !
> 
> Thomas Lübking wrote:
>     just ftr: afaics there's no way for a desktop wall (ie. treating all screens as one) left, is it?
>     personally i don't mind, but there might have been claims on this at kcd.
> 
> Alex Fiestas wrote:
>     As far as I understood you can disable xinerama to get just this, requires more digging but the option is still there.

xineramaEnabled is removed from the options.
disabling xinerama and configure two screens in xorg.conf will get you, well - two independent screens.
I don't know whether *enabling* xinerama in xorg.conf (and not using xrandr) will get you just one huge screen on the X11 layer, so that Kephal::ScreenUtils::screenGeometry(int) effectively turns Kephal::ScreenUtils::desktopGeometry() but xinerama is junk (tm) - at least not as convenient as xrandr.

Given there remains only "options->screenwall" and the crufty code in geometry.cpp this *could* be supported by kwin while still getting rid of most of that code.

Regarding workspace/toplevel: I guess it could still be removed.
We could still have n screens, including an active one, just treat them differently - esp. since the placing code in manage.cpp was redundant for the (regular?) "asn_data.xinerama() == -1" case, so it mostly condenses to that geometry code.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103756/#review10000
-----------------------------------------------------------


On Jan. 22, 2012, 10:21 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103756/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2012, 10:21 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> As discussed on the mailinglist: drop of the xinerama related options and the kcm. Given that the show unmanaged windows on option is in fact not used, I dropped the complete KCM.
> 
> 
> Diffs
> -----
> 
>   kcontrol/CMakeLists.txt 8cd9a46 
>   kcontrol/xinerama/CMakeLists.txt fe332e5 
>   kcontrol/xinerama/Messages.sh f4aa134 
>   kcontrol/xinerama/interface_util.h 8a4fcd1 
>   kcontrol/xinerama/kcmxinerama.h 18b9241 
>   kcontrol/xinerama/kcmxinerama.cpp a456b2c 
>   kcontrol/xinerama/test_kcm_xinerama.cpp a358a2c 
>   kcontrol/xinerama/xinerama.desktop e8ce525 
>   kcontrol/xinerama/xineramawidget.h 2c446a2 
>   kcontrol/xinerama/xineramawidget.cpp df9cb2f 
>   kcontrol/xinerama/xineramawidget.ui 90ec4d4 
>   kwin/geometry.cpp a414e26 
>   kwin/manage.cpp c551eac 
>   kwin/options.h 9dc29cf 
>   kwin/options.cpp d496569 
>   kwin/tabbox/tabbox.cpp 3051316 
>   kwin/toplevel.cpp ffe7f0c 
>   kwin/workspace.cpp 69b4ecb 
> 
> Diff: http://git.reviewboard.kde.org/r/103756/diff/diff
> 
> 
> Testing
> -------
> 
> Fullscreen: works
> Maximize: works
> Movment: works
> Placement: works
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120122/9381bbd6/attachment.html>