Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

[Ignat Semenov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103735/
-----------------------------------------------------------

(Updated Jan. 20, 2012, 9:35 a.m.)


Review request for Plasma, Aaron J. Seigo and Marco Martin.


Changes
-------

Remove qRound() and fix the issues pointed out by aseigo.


Description
-------

Currently, the FolderView::IconView::itemSize() method accounts for the margins only if size.width()>ts.width(), that is, the icon+margins is wider than the text. However, when ts.width()>size.width(), the margins are not accounted for, and size.width()=ts.width(). This can be observed easily. The patch adds those margins to the second operand of the comparison macro.


Diffs (updated)
-----

  plasma/applets/folderview/iconview.cpp 09b9c80 

Diff: http://git.reviewboard.kde.org/r/103735/diff/diff


Testing
-------

Tested by manually changing the paintItem() code to use the itemSize() rect and observing the improved behaviour.


Thanks,

Ignat Semenov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120120/a0c46e7e/attachment.html>