Review Request: Fix the issues introduced with the iconshrink patch

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103685/#review9786
-----------------------------------------------------------



plasma/applets/folderview/iconview.cpp
<http://git.reviewboard.kde.org/r/103685/#comment8098>

    Qt::AlignCenter	== Qt::AlignVCenter | Qt::AlignHCenter, so this could just be Qt::AlignCenter



plasma/applets/folderview/iconview.cpp
<http://git.reviewboard.kde.org/r/103685/#comment8096>

    this doesn't make much sense -> above the rect is aligned vertical and horizontal center, then it is moved to the top?



plasma/applets/folderview/iconview.cpp
<http://git.reviewboard.kde.org/r/103685/#comment8097>

    why 0.05? is this the amount the icon is shrunk by?


- Aaron J. Seigo


On Jan. 12, 2012, 7:40 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103685/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2012, 7:40 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> With the iconshrink patch, I introduced an issue with the icon text clipping. The thing is, the iconview items painting code is written in a way that the text will accomodate fully only if the icon touches the top of the rect r (iconview.cpp:1050), else the text will get clipped. TO achieve this effect, Qt:AlignTop had been used. I changed that to Qt:AlignCenter and introduced the issue.
> 
> This patch tries to locate the icon at the top border of the rect r (as it had been before the commit), but when the icon shrinks, it moves towards its own center, same as the first commit.
> 
> ir.moveTop(r.top());
> 
> Now when the icon is shrinked, it is moved down by half the difference between its normal size and its shrinked size, which is perfectly logical.
> 
> ir.translate(0, (m_drawIconShrinked && m_pressedIndex == index) ? 0.05*option.decorationSize.height() : 0);
> 
> This centers the icon nicely around its own center. The text keeps "scaling" towards the top as well, as it had been before the commit. In the idle state, the text is accomodated fully, as it had been before the commit.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/iconview.cpp d295588 
> 
> Diff: http://git.reviewboard.kde.org/r/103685/diff/diff
> 
> 
> Testing
> -------
> 
> This is not final, there is 1 pixel offset bug in the halo drawing code. I'm going to sleep today, this review request is just to show that I'm aware that I have screwed things up and am working on getting the proper patch done.
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120113/1661bb74/attachment-0001.html>