Review Request: Fix the double-click icon shrink issue in the FolderView applet

Marco Martin notmart at gmail.com
Thu Jan 12 15:50:12 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103679/#review9770
-----------------------------------------------------------

Ship it!


looks like it should work as intended

- Marco Martin


On Jan. 12, 2012, 3:39 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103679/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2012, 3:39 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> With KDE set to double-click, the icons in the FolderView applet would shrink twice on double-licking them. This is a visual glitch. The patch addresses that, shrinking the icon on the mouseDoubleClicked() event instead of the mousePressed() event if KDE is set to duble-click.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/iconview.h 38cad54 
>   plasma/applets/folderview/iconview.cpp 842e158 
> 
> Diff: http://git.reviewboard.kde.org/r/103679/diff/diff
> 
> 
> Testing
> -------
> 
> Tested, works both with KDe set ot single- and double-click.
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120112/d3019fa4/attachment.html>


More information about the Plasma-devel mailing list