Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

[Peter Penz]

> On Jan. 3, 2012, 5:24 p.m., Ignat Semenov wrote:
> > Sorry, was a misunderstanding among me and some plasma devs. Peter, we'd like to know the rationale for exposing such an option in the configuration UI.

When I implemented the selection-toggle in Dolphin for KDE 4.1 I was not sure how this feature will be perceived by the users (see also http://ppenz.blogspot.com/2008/04/selecting-items.html). Especially in the details-view, where the icon-size is usually very small, the selection-toggle hides the whole icon and I wanted to offer an explicit setting for users to turn the toggle off when single-click is used. So the reason for having this option was mainly that I did not have enough feedback at that time whether users will hate or love this feature.

The selection-toggle was initially not available when double-click is used, but to my surprise it has been requested to have it there too. Usecase: The toggle allows to deselect a selection in the double-click mode without pressing the CTRL-key. Since then the selection-toggle setting is completely orthogonal to the mouse-click setting.

In retrospective I would have done it the other way: Don't offer an explicit setting and just enable the selection-toggle in the single-click mode like in your patch. Based on the number of bug-reports I still could have introduced an option later. My problem now is that taking away an option afterwards is usually very problematic and also that I still don't even roughly know how much users have turned on or off the selection-toggle ;-)


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103618/#review9511
-----------------------------------------------------------


On Jan. 3, 2012, 5:21 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103618/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2012, 5:21 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Peter Penz.
> 
> 
> Description
> -------
> 
> This patch implements a proposal from the Netrunner project (netrunner-os.com), a KUbuntu derivative, aimed at polishing the KDE desktop, as part of my work for the project.
> 
> This feature allows the user to hide the "+" selection marker in the FolderView applet. It is absolutely symmetrical to the "Click to view folder" feature. The code is similar as well. One thing I had to change is the button hiding logic in ActionOverlay. The selection marker is positioned above the folder peek button, so it needs a QGraphicsGridLayout::removeItem() / ::addItem() instead of a QWidget::hide(), performed every time on the entered() event. As the ::removeItem() has to be called only once, I had to implement a public function that would toggle the button hiding / unhiding.
> 
> Then, to be symmetrical, I changed the folder peek button hiding code to use the same functions, with the same public interface in the ActionAoverlay class.
> 
> I hope the function addition is OK and does not violate neither incapsultion nor the KDE class design principles.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/actionoverlay.h 056c83b 
>   plasma/applets/folderview/actionoverlay.cpp 430e6dc 
>   plasma/applets/folderview/folderview.h c8869b4 
>   plasma/applets/folderview/folderview.cpp d620a7d 
>   plasma/applets/folderview/iconview.h 677aa76 
>   plasma/applets/folderview/iconview.cpp abf775e 
> 
> Diff: http://git.reviewboard.kde.org/r/103618/diff/diff
> 
> 
> Testing
> -------
> 
> Works fine.
> 
> The only problem is that following a recent Aaron's commit regarding configChanged() / configAccepeted() in the FolderView applet circa 2 weeks ago, the settings in this applet are applied only on Plasma restart and not on the fly after hitting the Appy or Ok buttons. Aaron, please, have a look into this. This happens with any settings, not onyl the ones I added. (My settings code is absolutely identical to the "Click to view folder" settigns code).
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120103/6b7f34e1/attachment.html>