Review Request: Fix "Add to desktop" from Kickoff when you have several virtual desktops and you enable "Different widgets for each desktop"

[Martin Gräßlin]

> On Jan. 6, 2012, 9:33 p.m., Martin Gräßlin wrote:
> > I just consulted the documentation and checked the properties on my system: that looks like KWindowSystem is wrong. The first desktop is 0. And further studies show that the bug might be in KWin. Will investigate further...

so just checked the relevant code in KWin and KWindowSystem: we start counting at 1 and just decrement/increment 1 when writing/reading the X property. Everything is fine with KWindowSystem reporting 1, the question is why Containment uses 0?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103645/#review9628
-----------------------------------------------------------


On Jan. 6, 2012, 9:11 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103645/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2012, 9:11 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> From Kickoff using "Add to desktop" when you have several virtual desktops and you enable "Different widgets for each desktop" in the pager settings. KWindowSystem starts counting from 1 and Plasma from 0
> 
> Without this fix "Add to desktop" adds to the next desktop or does not add if you're on the last desktop. 
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=290368.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290368
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp cf12903 
> 
> Diff: http://git.reviewboard.kde.org/r/103645/diff/diff
> 
> 
> Testing
> -------
> 
> Local tests as thorough as I could do.
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120106/9f0bb8ae/attachment.html>