Review Request: Fix bug https://bugs.kde.org/show_bug.cgi?id=270252

Marco Martin notmart at gmail.com
Mon Jan 2 10:55:34 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103597/#review9431
-----------------------------------------------------------

Ship it!


that's a very good catch ;)
yes, that's the way it's supposed to work.

qwidget level focus and qgraphicsscene level focus are two different beasts.

if there was another widget in that window besides the graphicsview (that is one single widget, just as a qpushbutton or whatnot) the reason this happens becomes more evident.

i think this should go in 4.8

- Marco Martin


On Dec. 31, 2011, 7:27 a.m., Nikita Churaev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103597/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2011, 7:27 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> For some reason, QGraphicsView must be focused too for its children to receive events. This however looks hacky. Please explain why it works to me.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/controllerwindow.cpp 6f3064f 
> 
> Diff: http://git.reviewboard.kde.org/r/103597/diff/diff
> 
> 
> Testing
> -------
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Nikita Churaev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120102/84157deb/attachment.html>


More information about the Plasma-devel mailing list