Review Request: Take sorting order into account in ProxyModel::lessThan() in order to give folders precedence regardless of the sort order used

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103884/#review10406
-----------------------------------------------------------


This review has been submitted with commit 74e44ad91b33268ef014cad32548d76517d848b1 by Ignat Semenov to branch KDE/4.8.

- Commit Hook


On Feb. 7, 2012, 7:40 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103884/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2012, 7:40 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik Höglund.
> 
> 
> Description
> -------
> 
> Currently, after the sort order patch https://git.reviewboard.kde.org/r/103860/, folders are moved to the bottom of the sorting list with the sorting order set to "Descending". This obviously is not what the author wanted to do with the option "Folders first", so this patch tries to place folders on top of the sorting list, even if they are still sorted according to the selected sorting order (which, in my opinion, is perfectly fine).
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/proxymodel.cpp ed28416 
> 
> Diff: http://git.reviewboard.kde.org/r/103884/diff/diff
> 
> 
> Testing
> -------
> 
> Tested, builds and works as described above.
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120207/120e5eef/attachment.html>