Review Request: Add Corona::addContainment feature to plasma-previewer

[Shaun Reich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103214/#review10372
-----------------------------------------------------------


patch looks great. thanks.

just some minor nitpicking with coding style...


previewer/plasmoid/plasmoidview.h
<http://git.reviewboard.kde.org/r/103214/#comment8543>

    need space after comma in &name,



previewer/plasmoid/plasmoidview.cpp
<http://git.reviewboard.kde.org/r/103214/#comment8542>

    need space after comma in QString &containment,const



previewer/plasmoid/plasmoidview.cpp
<http://git.reviewboard.kde.org/r/103214/#comment8541>

    need space between operators (in this case, +)



previewer/plasmoid/plasmoidview.cpp
<http://git.reviewboard.kde.org/r/103214/#comment8540>

    need space between ( in if(


- Shaun Reich


On Nov. 23, 2011, 10:29 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103214/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 10:29 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Hello
> 
> This patch is add the containment feature to the plasma-previewer.
> 
> 
> Diffs
> -----
> 
>   previewer/plasmoid/plasmoidview.h 6ffd330 
>   previewer/plasmoid/plasmoidview.cpp 3d40d48 
>   previewer/plasmoid/test/main.cpp 609b595 
> 
> Diff: http://git.reviewboard.kde.org/r/103214/diff/diff
> 
> 
> Testing
> -------
> 
> plasmate compiles fine and plasma-previewer -c behaves like the plasmoidviewer -c....
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120206/eb100c36/attachment.html>