Review Request: Plasma HDD Activity/IO system monitor applet creation

[Shaun Reich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103878/
-----------------------------------------------------------

Review request for Plasma, Aaron J. Seigo and Marco Martin.


Description
-------

Made a plasma applet that monitors hard disk I/O, aka throughput/activity.

Planning on merging it into master workspace, as the other sysmon applets are there, and hdd activity is actually a really common request.

it should be Most Probably Totally Bug Free™ as well. though i'm having difficulties testing the case for when it's in the panel, but i can test & fix once it gets merged easily.

I apologize for how nasty the diff looks...i'm surprised reviewboard doesn't have an ability to just upload a file and diff it against nothing.

a lot of the bugs related to this applet and the other applets, are due to the main base class that all of them derive from, so i will fix more of that/those soon as well (i've already fixed quite a few of them).


Diffs
-----

  plasma/generic/applets/system-monitor/CMakeLists.txt 0f74eb6 
  plasma/generic/applets/system-monitor/hdd-activity-config.ui e641c8a 
  plasma/generic/applets/system-monitor/hdd_activity-config.ui PRE-CREATION 
  plasma/generic/applets/system-monitor/hdd_activity.h f74af85 
  plasma/generic/applets/system-monitor/hdd_activity.cpp 5762d6d 
  plasma/generic/applets/system-monitor/plasma-applet-sm_hdd_activity.desktop d3bb6b6 

Diff: http://git.reviewboard.kde.org/r/103878/diff/diff


Testing
-------

42


Thanks,

Shaun Reich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120206/df054fc3/attachment.html>