Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEvent() in FolderView::IconView

[Fredrik Höglund]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103822/#review10360
-----------------------------------------------------------

Ship it!


Aside from some minor nitpicks, it looks good.


plasma/applets/folderview/iconview.cpp
<http://git.reviewboard.kde.org/r/103822/#comment8527>

    Make these const. There is also a whitespace error on this line.



plasma/applets/folderview/iconview.cpp
<http://git.reviewboard.kde.org/r/103822/#comment8526>

    Change the name of this variable to 'rect'.


- Fredrik Höglund


On Jan. 29, 2012, 3:54 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103822/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 3:54 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch aims to save some repaints in FolderView::IconView on the various mouseEvent()'s by choosing what to repaint in a bit smarter way.
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/iconview.h 66ccb98 
>   plasma/applets/folderview/iconview.cpp 5b0cd98 
> 
> Diff: http://git.reviewboard.kde.org/r/103822/diff/diff
> 
> 
> Testing
> -------
> 
> Testing done against master, seems to behave indentically.
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120205/c878cb79/attachment.html>