Review Request: Allow to choose between ascending and descending icon sort order in folderview

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103860/#review10327
-----------------------------------------------------------


apart the small issue below, almost good to go


plasma/applets/folderview/folderview.cpp
<http://git.reviewboard.kde.org/r/103860/#comment8513>

    save in the config directly the enum values as integers



plasma/applets/folderview/folderview.cpp
<http://git.reviewboard.kde.org/r/103860/#comment8514>

    this shouldn't exist as well, only Qt::SortOrder should be passed around



plasma/applets/folderview/folderview.cpp
<http://git.reviewboard.kde.org/r/103860/#comment8515>

    config().writeEntry("sortOrder", m_sortOrder);


- Marco Martin


On Feb. 3, 2012, 6:29 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103860/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2012, 6:29 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch allows to select between acsending and descending icon sort order in folderview.
> 
> THe QVariant() and the short-circuit if's in cg.readEntry() / cg.writeEntry() stem from the fact that Qt::SortOrder can not be converted to an int, and needs to be operated this way. Thanks go to dfaure for explaining me how to do deal with the enum problem.
> 
> 
> This addresses bug 180646.
>     http://bugs.kde.org/show_bug.cgi?id=180646
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/folderview.h e458d77 
>   plasma/applets/folderview/folderview.cpp 54ea14a 
> 
> Diff: http://git.reviewboard.kde.org/r/103860/diff/diff
> 
> 
> Testing
> -------
> 
> Tested, works. Changes the icon sort direction, even though the actual sorting is sometimes broken (my next task, most probably.)
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120203/6e05e831/attachment.html>