Review Request: Apply the IconView model settings to the PopupView in the PopupView constructor for consistency

Commit Hook null at kde.org
Fri Feb 3 11:10:58 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103851/#review10312
-----------------------------------------------------------


This review has been submitted with commit dafd25bc94b284d93acf56a6e8ea3d8f9148b4a2 by Ignat Semenov to branch master.

- Commit Hook


On Feb. 2, 2012, 6:44 p.m., Ignat Semenov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103851/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2012, 6:44 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> Apply the necessary model settings to the ProxyModel object in PopupView::PopupView(...) identically to the FolderView::init() method. This fixes bug 211002.
> 
> 
> This addresses bug 211002.
>     http://bugs.kde.org/show_bug.cgi?id=211002
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/popupview.h 0243b2f 
>   plasma/applets/folderview/popupview.cpp 7fdb3f7 
> 
> Diff: http://git.reviewboard.kde.org/r/103851/diff/diff
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Ignat Semenov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120203/0d025e18/attachment.html>


More information about the Plasma-devel mailing list