Review Request: Reusable qml components for mediabrowsing

Shantanu Tushar shantanu at kde.org
Sun Dec 23 14:10:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107861/#review23907
-----------------------------------------------------------

Ship it!


Ship It!


components/MediaGridItemDelegate.qml
<http://git.reviewboard.kde.org/r/107861/#comment18232>

    will this not be used? If yes, remove it


- Shantanu Tushar


On Dec. 23, 2012, 8:33 a.m., Fabian Riethmayer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107861/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 8:33 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> First reusable qml components for mediabrowsing.
> Description of the browsers http://community.kde.org/Plasma/Plasma_Media_Center/Media_Browser
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt f7f2366 
>   browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml a66123e 
>   browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/qmldir 3f2f55d 
>   components/CMakeLists.txt PRE-CREATION 
>   components/MediaGridBrowser.qml PRE-CREATION 
>   components/MediaGridItemDelegate.qml PRE-CREATION 
>   components/MediaItemDelegateLogic.js PRE-CREATION 
>   components/MediaLineItemDelegate.qml PRE-CREATION 
>   components/MediaListBrowser.qml PRE-CREATION 
>   components/TabBrowser.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107861/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian Riethmayer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121223/7d843449/attachment.html>


More information about the Plasma-devel mailing list