Review Request: Fix dismissing LastNotificationPopup often failing
Kai Uwe Broulik
kde at privat.broulik.de
Tue Dec 25 14:43:49 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/
-----------------------------------------------------------
Review request for Plasma and Marco Martin.
Description
-------
This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event.
Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications.
This addresses bug 311413.
http://bugs.kde.org/show_bug.cgi?id=311413
Diffs
-----
plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b
Diff: http://git.reviewboard.kde.org/r/107908/diff/
Testing
-------
kdialog --passivepopup "bla"
click, closes.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121225/5485017c/attachment.html>
More information about the Plasma-devel
mailing list