Review Request: Make sure ksmserver ignores excluded apps when saving session
Commit Hook
null at kde.org
Mon Dec 24 14:06:10 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107276/#review23954
-----------------------------------------------------------
This review has been submitted with commit 7a99d5708f9ba2bedbc197c740f8b64f81c6f575 by Jekyll Wu to branch KDE/4.9.
- Commit Hook
On Dec. 9, 2012, 7:50 a.m., Jekyll Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107276/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2012, 7:50 a.m.)
>
>
> Review request for kdelibs, Plasma and Luboš Luňák.
>
>
> Description
> -------
>
> It is easy to understand why the existing code (usually) fails:
>
> * Users are most likely to just specify short names, like "dolphin,gwenview,okular,rekonq", instead of "/usr/bin/konsole,/usr/bin/gwenview,/usr/bin/okular,/usr/bin/rekonq"
>
> * When ksmserver saves the session, it usually gets the full names, like "/usr/bin/dolphin", unless you have started that dolphin instance by typing "dolphin" exactly in a shell.
>
>
> So there are four possible combinations :
>
> 1). config uses short name, runtime gets short name (this guy starts everything from konsole, never using kio/krun)
> 2). config uses short name, runtime gets long name (I think this is the most common one)
> 3). config uses long name, runtime gets short name
> 4). config uses long name, runtime gets long name (I guess some users use this combination because they find only that way works after trying various workaround...)
>
> The existing code works with 1) and 4), the patch now works with 1), 2) and 4) . I don't know whether it make senses to support all combinations .
>
>
>
>
>
> This addresses bug 242760.
> http://bugs.kde.org/show_bug.cgi?id=242760
>
>
> Diffs
> -----
>
> ksmserver/server.cpp a65b35a
>
> Diff: http://git.reviewboard.kde.org/r/107276/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jekyll Wu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121224/041ce534/attachment.html>
More information about the Plasma-devel
mailing list