Review Request: show notification summary for last popup notification

Commit Hook null at kde.org
Mon Dec 24 04:28:00 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107743/#review23937
-----------------------------------------------------------


This review has been submitted with commit 579b860460dcd5c54352fb0a4201ece955b2433b by Weng Xuetian to branch master.

- Commit Hook


On Dec. 23, 2012, 6:16 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107743/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2012, 6:16 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> New qml notification doesn't show summary for last popup notification. This patch add summary back.
> 
> 
> This addresses bug 307670.
>     http://bugs.kde.org/show_bug.cgi?id=307670
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
>   plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 9e4345a 
> 
> Diff: http://git.reviewboard.kde.org/r/107743/diff/
> 
> 
> Testing
> -------
> 
> No problem here. Looks ok.
> 
> 
> Screenshots
> -----------
> 
> current appearance
>   http://git.reviewboard.kde.org/r/107743/s/899/
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121224/b9fa80d3/attachment.html>


More information about the Plasma-devel mailing list