Review Request: show notification summary for last popup notification

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107743/
-----------------------------------------------------------

(Updated Dec. 23, 2012, 6:16 p.m.)


Review request for Plasma and Marco Martin.


Changes
-------

a better way to solve overflow and vertical center.

Currently if body text is overflowed, it need to align with top, so size need to be shrinked in this case.


Description
-------

New qml notification doesn't show summary for last popup notification. This patch add summary back.


This addresses bug 307670.
    http://bugs.kde.org/show_bug.cgi?id=307670


Diffs (updated)
-----

  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 9e4345a 

Diff: http://git.reviewboard.kde.org/r/107743/diff/


Testing
-------

No problem here. Looks ok.


Screenshots
-----------

current appearance
  http://git.reviewboard.kde.org/r/107743/s/899/


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121223/cef8e415/attachment-0001.html>