Review Request: load the images for the themes correctly

Giorgos Tsiapaliokas terietor at gmail.com
Sun Dec 23 15:23:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106680/
-----------------------------------------------------------

(Updated Dec. 23, 2012, 3:23 p.m.)


Review request for Plasma.


Changes
-------

>Thinking about it some more, all named files should be shown.

yes and it works :)

The themes are working correct and also there was one more file like the colors.
It was the mainconfigui, so I have added it in the ui like the main.xml.
If the mainconfigui doesn't exist add it in the top entries else add it where it belongs.


Description
-------

create a new theme package->click on the new

a file dialog should appear but instead a simple edit box appears requesting a new filename.

This patch solves the issue


Diffs (updated)
-----

  plasmate/editors/editpage.h 5cb3ea6 
  plasmate/editors/editpage.cpp 7e82ff2 
  plasmate/packagemodel.h efa3001 
  plasmate/packagemodel.cpp 9eb0914 

Diff: http://git.reviewboard.kde.org/r/106680/diff/


Testing
-------


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121223/a9f8d664/attachment.html>


More information about the Plasma-devel mailing list