Review Request: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does
Jekyll Wu
adaptee at gmail.com
Sun Dec 23 12:26:55 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107868/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
What the current konquerorsessions plugin does is eventually calling "konqueror --profile xyz", so it is really for the profile feature of konqueror, not the session feature of konqueoror.
The patch just contains various moving and renaming opeations to make its code, name and behavior being consistent. I actually have made a real konquerosessions plugin based upon this unreal plugin. Will post it in another review.
This addresses bug 188494.
http://bugs.kde.org/show_bug.cgi?id=188494
Diffs
-----
runners/CMakeLists.txt bb4b491
runners/konquerorprofiles/CMakeLists.txt PRE-CREATION
runners/konquerorprofiles/Messages.sh PRE-CREATION
runners/konquerorprofiles/konquerorprofiles.cpp PRE-CREATION
runners/konquerorprofiles/konquerorprofiles.desktop PRE-CREATION
runners/konquerorprofiles/konquerorprofiles.h PRE-CREATION
runners/konquerorsessions/CMakeLists.txt be2ea9d
runners/konquerorsessions/Messages.sh 0720e1e
runners/konquerorsessions/konquerorsessions.cpp f2e437a
runners/konquerorsessions/konquerorsessions.desktop df81780
runners/konquerorsessions/konquerorsessions.h 957f976
Diff: http://git.reviewboard.kde.org/r/107868/diff/
Testing
-------
Thanks,
Jekyll Wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121223/0f93fb9e/attachment.html>
More information about the Plasma-devel
mailing list