Review Request: show notification summary for last popup notification

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107743/#review23571
-----------------------------------------------------------


Works here, although there could be a bit of top margin if the panel is at the top of the screen, on other screen edges looks good.
And maybe the title label should be hidden if it is empty?


plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml
<http://git.reviewboard.kde.org/r/107743/#comment18093>

    Seems to have no effect here, and font shouldn't be bold since it is not bold in the notification list.


- Kai Uwe Broulik


On Dec. 15, 2012, 9:17 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107743/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 9:17 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> New qml notification doesn't show summary for last popup notification. This patch add summary back.
> 
> 
> This addresses bug 307670.
>     http://bugs.kde.org/show_bug.cgi?id=307670
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
> 
> Diff: http://git.reviewboard.kde.org/r/107743/diff/
> 
> 
> Testing
> -------
> 
> No problem here. Looks ok.
> 
> 
> Screenshots
> -----------
> 
> current appearance
>   http://git.reviewboard.kde.org/r/107743/s/899/
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20121216/929dcd2a/attachment.html>